Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DSL support for JaCoCo Line Coverage column via 'jacoco' method #729

Merged
merged 2 commits into from
Jan 20, 2016
Merged

Add DSL support for JaCoCo Line Coverage column via 'jacoco' method #729

merged 2 commits into from
Jan 20, 2016

Conversation

drwoods
Copy link
Contributor

@drwoods drwoods commented Jan 19, 2016

Passed build.
Ran embedded server and installed JaCoCo 2.0.1 plugin to verify the following Job DSL -

listView("TestView") {
  columns {
    status()
    weather()
    name()
    lastSuccess()
    lastFailure()
    lastDuration()
    jacoco()
  }
  jobs {
  }
}

Generated a List View that I could then add the above job to and see that the view included the column and the View XML was correct -

<?xml version="1.0" encoding="UTF-8"?>
<hudson.model.ListView>
  <name>TestView</name>
  <filterExecutors>false</filterExecutors>
  <filterQueue>false</filterQueue>
  <properties class="hudson.model.View$PropertyList"/>
  <jobNames>
    <comparator class="hudson.util.CaseInsensitiveComparator"/>
    <string>TestDSL</string>
  </jobNames>
  <jobFilters/>
  <columns>
    <hudson.views.StatusColumn/>
    <hudson.views.WeatherColumn/>
    <hudson.views.JobColumn/>
    <hudson.views.LastSuccessColumn/>
    <hudson.views.LastFailureColumn/>
    <hudson.views.LastDurationColumn/>
    <hudson.plugins.jacococoveragecolumn.JaCoCoColumn plugin="jacoco@2.0.1"/>
  </columns>
  <recurse>false</recurse>
</hudson.model.ListView>

@drwoods
Copy link
Contributor Author

drwoods commented Jan 19, 2016

When the updated plugin is used in a job to add the jacoco column to the List View, it causes the build to be marked as Unstable due to -
Warning: (script, line 241) version 1.0 or later of plugin 'jacoco-column' needs to be installed

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@drwoods
Copy link
Contributor Author

drwoods commented Jan 20, 2016

Updated commit that fixes the plugin id, which removes the Warning so the resultant build will now be marked Stable.

@daspilker daspilker merged commit 66e5c20 into jenkinsci:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drwoods @jenkinsadmin @daspilker